Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an OnEveryFailure notification option #520

Closed
sghill opened this issue Feb 15, 2019 · 3 comments · Fixed by #564
Closed

Introduce an OnEveryFailure notification option #520

sghill opened this issue Feb 15, 2019 · 3 comments · Fixed by #564

Comments

@sghill
Copy link
Contributor

sghill commented Feb 15, 2019

Adding a new option to subscribe to notifications on every failure would be helpful to most users of the plugin. Split from comments on PR #516:

Gah, there should be an OnEveryFailure one imo, this behaviour is just confusing
At least I can now tell what's going on with this code

Originally posted by @timja in #516

related: #519, #518, #136, #134, #15

@movedoa
Copy link

movedoa commented Feb 22, 2019

+1, very confusing.
Also, wouldn't it make more sense to use a radioset for the 2 (then 3) options?
Afaik it doesn't make sense to have more than one active at a time.

@jetersen
Copy link
Member

jetersen commented Feb 22, 2019

I think it would be better to have onEveryFailure and onFirstFailure.
Since onRepeatedFailure is covered by onEveryFailure...
Perhaps just convert onRepeatedFailure to onEveryFailure inside the code.

@philosowaffle
Copy link

+1 for OnEveryFailure or something equivalent. Perhaps we could also get the README updated with the different configuration options and a description on how they work. That way, even if the config names are confusing, there is a reference document with a proper explanation.

sghill added a commit to sghill/slack-plugin that referenced this issue Apr 20, 2019
Move the first/repeated failure options into the Advanced section

Fixes jenkinsci#520
timja pushed a commit that referenced this issue Apr 24, 2019
Move the first/repeated failure options into the Advanced section

Fixes #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants