fix: display value json input #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computing the display value should retain the original value type of the value. For example if the value is of type string but the contents of the string resemble a primitive value the some information may get lost. Given an value list of strings `["2024.20", "2024.0"]` the json string passed to `parseDisplayValue` would be the the values `2024.20` and `2024.0`, which when re-parsed as json values will be interpreted as numbers rather than strings. This has the end effect of the display values `2024.2` and `2024` while the associated values are `2024.20` and `2024.0`. To fix this behavior each value is "json stringified" before sent to `parseDisplayValue`. For the example above the values would be `"2024.20"` and `"2024.0"`.
mymarche
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Computing the display value should retain the original value type of the value. For example if the value is of type string but the contents of the string resemble a primitive value the some information may get lost.
Given an value list of strings
["2024.20", "2024.0"]the json string passed toparseDisplayValuewould be the the values2024.20and2024.0, which when re-parsed as json values will be interpreted as numbers rather than strings. This has the end effect of the display values2024.2and2024while the associated values are2024.20and2024.0.Changes
To fix this behavior each value is "json stringified" before sent to
parseDisplayValue. For the example above the values would be"2024.20"and"2024.0".