Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing credential lookup context #155

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: missing credential lookup context #155

merged 1 commit into from
Aug 25, 2022

Conversation

h1dden-da3m0n
Copy link
Contributor

Description

This PR aims to fix misleading success in config test, but failure on proper run.

Changes

  • lookup request context when getting REST values and pass it to credential lookup

Issues

@h1dden-da3m0n
fix: missing credential lookup context
648bd16 
fixes misleading success in config test, but failure on proper run
@h1dden-da3m0n h1dden-da3m0n added the bug Something isn't working label Aug 21, 2022
@h1dden-da3m0n h1dden-da3m0n requested a review from a team as a code owner August 21, 2022 14:16
@h1dden-da3m0n h1dden-da3m0n mentioned this pull request Aug 21, 2022
Closed
@h1dden-da3m0n h1dden-da3m0n merged commit e91e397 into main Aug 25, 2022
@h1dden-da3m0n h1dden-da3m0n deleted the fix/gh-154 branch August 25, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Only global jenkins credentials are passed if REST/Web endpoint requires authentication
1 participant
@h1dden-da3m0n