fix: refresh values list if empty on param value creation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents odd caching behaviour in certain situations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to rectify a logic issue in this plugins code that was not taken into account when initially creating it.
Basically, other plugins such as the Parameterized Scheduler only call the
createValuemethod and would run into issues unless the parameter where to be initialized first from a previous call. This is due to the values list currently only initializing and filling whengetValuesgets called (i.e. when attempting to trigger a new job with the parameter).Is this an ideal solution? No, however, in lack of a better workaround this basically ensures that the valid values list is not empty when
createValuegets called.Changes
Issues