Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inefficient string equals use #105

Merged
merged 1 commit into from
Nov 20, 2021
Merged

fix: inefficient string equals use #105

merged 1 commit into from
Nov 20, 2021

Conversation

h1dden-da3m0n
Copy link
Contributor

Description

This PR fixes an inefficient use of String.equals() that snuck by.

Changes

  • change use pf String.equals("") to String.isEmpty()

Issues

  • n/a

@h1dden-da3m0n h1dden-da3m0n added the chore This is a maintenance PR label Nov 20, 2021
@h1dden-da3m0n h1dden-da3m0n requested a review from a team as a code owner November 20, 2021 14:43
@h1dden-da3m0n h1dden-da3m0n merged commit 0c17036 into main Nov 20, 2021
@h1dden-da3m0n h1dden-da3m0n deleted the fix/string-equals-use branch November 20, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore This is a maintenance PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@h1dden-da3m0n