-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter #8
Conversation
…word parameter Added global configuration option to (not) remember password
…arameter -Replaced if jelly tag by choose -fixed global jelly to show documentation -imrpoved documentation -added license -added javadoc
Jenkins » rebuild-plugin #35 SUCCESS |
…arameter -added default true
Jenkins » rebuild-plugin #36 SUCCESS |
From what I can see you are attempting to only add a global setting on the Jenkins config page. It would be better to add that in PluginImpl's config or a separate jenkins.model.GlobalConfiguration implementation. |
Jenkins » rebuild-plugin #39 FAILURE |
Looks like there is something wrong with the buildserver: http://jenkins.361315.n4.nabble.com/Could-not-find-artifact-org-jenkins-ci-tools-maven-hpi-plugin-jar-1-90-in-central-td4661095.html |
… with Extended Choice Parameter Added the Jelly file that makes it possible to change the value of the parameter when rebuilding (simple string input box). Unfortunately the type of parameter is not serialized in the job, so it's hard to present a nice gui when rebuilding based on the type of extended choice parameter. We could use the current job configuration, however this might conflict with builds that ran in the past with a different configuration.
Jenkins » rebuild-plugin #40 SUCCESS |
Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter
*/ | ||
public boolean getRememberPasswordEnabled() { | ||
return rememberPasswordEnabled; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File has not been described in the PR
Added a global configuration option to not remember the value of a password field for paramterized builds. Defaults to true to be in line with the previous versions of the plugin.