Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter #8

Merged
merged 7 commits into from
Jul 22, 2013

Conversation

rinokadijk
Copy link
Contributor

Added a global configuration option to not remember the value of a password field for paramterized builds. Defaults to true to be in line with the previous versions of the plugin.

…word parameter

Added global configuration option to (not) remember password
…arameter

-Replaced if jelly tag by choose
-fixed global jelly to show documentation
-imrpoved documentation
-added license
-added javadoc
@buildhive
Copy link

Jenkins » rebuild-plugin #35 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Jenkins » rebuild-plugin #36 SUCCESS
This pull request looks good
(what's this?)

@rsandell
Copy link
Member

rsandell commented Apr 8, 2013

From what I can see you are attempting to only add a global setting on the Jenkins config page.
Turning the action into a notifier is a bit overkill and adds a bit of unnecessary complexity IMHO.

It would be better to add that in PluginImpl's config or a separate jenkins.model.GlobalConfiguration implementation.

@buildhive
Copy link

Jenkins » rebuild-plugin #39 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@rinokadijk
Copy link
Contributor Author

… with Extended Choice Parameter

Added the Jelly file that makes it possible to change the value of the parameter when rebuilding (simple string input box). Unfortunately the type of parameter is not serialized in the job, so it's hard to present a nice gui when rebuilding based on the type of extended choice parameter. We could use the current job configuration, however this might conflict with builds that ran in the past with a different configuration.
@buildhive
Copy link

Jenkins » rebuild-plugin #40 SUCCESS
This pull request looks good
(what's this?)

rsandell added a commit that referenced this pull request Jul 22, 2013
Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter
@rsandell rsandell merged commit 50f9bf3 into jenkinsci:master Jul 22, 2013
*/
public boolean getRememberPasswordEnabled() {
return rememberPasswordEnabled;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File has not been described in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants