Proxy for credentials #10
Conversation
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
|
||
| private static final long serialVersionUID = 1L; | ||
| public static final int DEFAULT_PORT = 22; | ||
| public static final int DEFAULT_TIMEOUT = 300000; | ||
| public static final String CONFIG_KEY_PREFERRED_AUTHENTICATIONS = "PreferredAuthentications"; | ||
| private static final Log LOG = LogFactory.getLog(BapSshHostConfiguration.class); | ||
| public static final String HTTP_PROXY_TYPE = "http"; |
There was a problem hiding this comment.
Are these not already defined in the jsch library somewhere?
There was a problem hiding this comment.
does not seem to be definied neither in com.jcraft.jsch.Proxy or sibling classes, nor in java.net.Proxy
|
I have upgraded to 1.554.3 the oldest LTS that allows the DataBoundSetter. I have cleanup the code accordingly. Thanks in advance |
|
My apologies, I wasn't meaning for you to decompose the whole constructor into DataBoundSetters, just the new field(s) that you were adding. This would maintain the constructor that was already there, but allow for adding new things to the configuration. |
|
ok for you if I revert the constructor only ? |
5e5de00 to
3b968f1
Compare
|
Yeah, that should be ok |
|
should be done, i've also squashed everything to one commit |
|
nice, any plan for the release ? thanks |
This pull request adds a new section in "Configuration" form in order to configure an internet proxy for SSH connection.
Based on a feature of JSCH, an HTTP, SOCKS4 or SOCKS5 proxy can be configured. A type of proxy, url and port of proxy server, and optionally username and password can be specified.