Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68320] Fix: use modern Jenkins icon for failed promotions in build history panel #187

Merged
merged 10 commits into from
Jan 4, 2024

Conversation

rafalhejna
Copy link
Contributor

@rafalhejna rafalhejna commented Apr 20, 2022

Fix for the missing Jenkins error icons for failed promotions in build history panel. I've removed references to error.png file and replaced them with l:icon declarations.

Before
before

After
after1

See JENKINS-68320.

Your checklist for this pull request

  • Pull request title represents the changelog entry which will be used in Release Notes. JIRA issue is a part of the title (see existing PRs as examples)
  • Please describe what you did. Short summary for reviewers. If the change involves WebUI, add screenshots
  • Link to relevant Jenkins JIRA issues or pull requests
  • Test automation, if relevant. We expect autotests for all new features or complex bugfixes
  • Documentation if relevant (new features). We want to use Documentation-as-Code, just put docs to README or to new Doc files
  • Javadoc for new APIs. Any public/protected method is considered as API unless annotated by Restricted (docs)

CC

@oleg-nenashev

@MarkEWaite MarkEWaite added the bug label May 29, 2023
NotMyFault
NotMyFault previously approved these changes Jan 4, 2024
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@rafalhejna rafalhejna requested a review from a team as a code owner January 4, 2024 08:41
@NotMyFault NotMyFault merged commit 597f5c6 into jenkinsci:master Jan 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants