Merge pull request #34 from StefanSpieker/minor_stuff

Refactoring: Use diamond operator and removed unnecessary semicolon and import
jenkinsci · Dec 26, 2022 · 58f5cd2 · 58f5cd2
2 parents 332220c + f082970
commit 58f5cd2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/pluginusage/JobsPerPlugin.java b/src/main/java/org/jenkinsci/plugins/pluginusage/JobsPerPlugin.java
@@ -2,7 +2,6 @@
 
 import hudson.PluginWrapper;
 import hudson.model.Item;
-import hudson.model.Job;
 import org.kohsuke.stapler.export.Exported;
 import org.kohsuke.stapler.export.ExportedBean;
 
@@ -16,7 +15,7 @@
 public class JobsPerPlugin {
 
 	private PluginWrapper plugin;
-	private Map<String, Item> jobMap = new HashMap<String, Item>();
+	private Map<String, Item> jobMap = new HashMap<>();
 
 
 	public JobsPerPlugin(PluginWrapper plugin) {
@@ -29,8 +28,7 @@ public void addProject(Item project) {
 
 	@Exported
 	public List<Item> getProjects() {
-		ArrayList<Item> projects = new ArrayList<Item>();
-		projects.addAll(jobMap.values());
+		ArrayList<Item> projects = new ArrayList<>(jobMap.values());
 		projects.sort(Comparator.comparing(Item::getName));
 		return projects;
 	}

diff --git a/src/test/java/org/jenkinsci/plugins/pluginusage/JenkinsClient.java b/src/test/java/org/jenkinsci/plugins/pluginusage/JenkinsClient.java
@@ -274,7 +274,7 @@ public Void installPluginUsage() {
 
             try (
                     OutputStream output = connection.getOutputStream();
-                    PrintWriter writer = new PrintWriter(new OutputStreamWriter(output, charset), true);
+                    PrintWriter writer = new PrintWriter(new OutputStreamWriter(output, charset), true)
             ) {
                 // Send binary file.
                 writer.append("--").append(boundary).append(CRLF);