Link back to the Jenkins javadoc. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since most plugins will use classes from Jenkins we should link the javadoc so you can navigate to the Jenkins javadoc similar to linking to the J2SE javadoc
jtnord
commented
Oct 30, 2017
| @@ -657,6 +657,11 @@ | |||
| </goals> | |||
| <!-- As soon as possible but after required generate-sources phase --> | |||
| <phase>process-sources</phase> | |||
| <configuration> | |||
| <links> | |||
| <link>http://javadoc.jenkins.io/</link> | |||
There was a problem hiding this comment.
this site is not yet SSL enabled :-(
There was a problem hiding this comment.
File/reference an INFRA ticket @jtnord ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh you mean about ssl on javadoc.jenkins.io :-)
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
daniel-beck
approved these changes
Oct 30, 2017
|
@reviewbybees done |
|
given I do not expect anyone in the community to disagree with this change merging early |
|
Belated 🐝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most plugins will use classes from Jenkins we should link the
javadoc so you can navigate to the Jenkins javadoc similar to linking to
the J2SE javadoc
Tested on a local plugin that the links to the jenkins javadoc and the Oracle J2SE javadocs are created.
@reviewbybees