[JENKINS-66247] Do not override the version of annotation-indexer from core

[jglick]

#424 should not have overridden the version of this library. See jenkinsci/pipeline-model-definition-plugin#443.

For now, just run ITs against a version of core containing jenkinsci/jenkins#5208. The better fix will be to make access-modifier-checker capable of reading both the old and new index location.

[MarkEWaite]

Git plugin 4.8.0 was released with plugin pom 4.20. Git plugin 4.8.1 was released with plugin pom 4.21. Git client plugin 3.9.0 was released with plugin pom 4.21.

When I try to update them to use plugin pom 4.23, the CI job fails with access modifier errors for the Messages class. See https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1122/1/console and https://ci.jenkins.io/job/Plugins/job/git-client-plugin/view/change-requests/job/PR-729/1/console for examples of the failures.

I believe that it is legal to access the Messages class, at least according to https://www.jenkins.io/doc/developer/internationalization/prepare-a-java-source-file/#step-4-reference-messages-strings and https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#views-and-other-resources . If not, can you suggest the correct change to allow those plugins to use plugin pom 4.23?

[bitwiseman]

Same on scm-api-plugin: jenkinsci/scm-api-plugin#89

[jglick]

It is legal to access Messages from inside your own plugin of course. Not from other plugins. I will try to figure out what is going on here.

[jglick]

Will track in #428. Sorry for the regressions piled on top of regressions!