[JENKINS-55456] Upgrade PowerMock version to 2.0.0 #148
Conversation
There was a problem hiding this comment.
Release note: 2.0.0 <-> 2.0.0-RC.4
Note as "enhancement", they remove some deprecated code parts issue 839. That could potentially lead to some regressions.
|
Please file downstream PRs on some critical plugins to assess this using a timestamped SNAPSHOT, ideally plugins using powermock. From a cursory look, it would look like a passing PR on both Thanks! |
| @@ -205,12 +205,12 @@ | |||
| <dependency> | |||
| <groupId>org.powermock</groupId> | |||
| <artifactId>powermock-module-junit4</artifactId> | |||
| <version>2.0.0-RC.4</version> | |||
| <version>2.0.0</version> | |||
There was a problem hiding this comment.
it was a complete shock to me that this was even included - personally I feel neither mocito nor powermock should be in here and it is up to the individual plugins to use them if they desire.
for example if a new plugin includes a test project from a plugin built with older parent the dependency will automatically be shunted and is liable o break things.
/shrug
There was a problem hiding this comment.
It's in the dependencyManagement. So we don't force anyone to use them, just we put a recommended version, so plugins can add those dependencies in their pom.xml without a version.
Also, if any plugin wants a different version, they can put a version to use and this will be ignored.
There was a problem hiding this comment.
Yes, it was deliberate since we have got a lot of fun while testing with Java 11
There was a problem hiding this comment.
Also, if any plugin wants a different version, they can put a version to use and this will be ignored
for an individual plugin yes, but if another plugin depends on that plugin no, the dependency gets overridden
|
Ping @alecharp. Have a great weekend! |
|
@batmat I'm working on the PR for |
This is to validate jenkinsci/plugin-pom#148 and the fact that PowerMock 2.0.0 is not breaking plugins' validation process.
|
🚢 🇮🇹 ? |
|
It seems that the PR in Git Plugin is building correctly. See jenkinsci/git-plugin#662. Maybe we could merge this. |
JENKINS-55456
Upgrade
powermockJunit and Mockito libraries from2.0.0-RC.4to2.0.0.