[JENKINS-75090] Fix horizontal radio button overlap with later element #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.jenkins.io/browse/JENKINS-75090 notes that Jenkins 2.479.x shows a different layout of the horizontal radio buttons that are created by this plugin. Horizontal radio buttons are not in the Jenkins design library. The horizontal radio buttons should be replaced in this plugin with standard components from the Jenkins design library. However, that is a larger effort and will need more time. This small change fixes the visual issue without replacing the entire configuration page. Insert extra space between the overlapping elements to prevent overlap. Not an elegant fix, but no worse than the current implementation and much faster than replacing the entire configuration page with a new implementation. Testing done: * Confirmed user interface does not overlap in 2.479.2 and 2.462.3 * Confirmed that the additional space is not too ugly on 2.462.3
gounthar
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JENKINS-75090] Fix horizontal radio button overlap with later element
JENKINS-75090 notes that Jenkins 2.479.x shows a different layout of the horizontal radio buttons that are created by this plugin. Horizontal radio buttons are not in the Jenkins design library. The horizontal radio buttons should be replaced in this plugin with standard components from the Jenkins design library. However, that is a larger effort and will need more time. This small change fixes the visual issue without replacing the entire configuration page.
Insert extra space between the overlapping elements to prevent overlap. Not an elegant fix, but no worse than the current implementation and much faster than replacing the entire configuration page with a new implementation.
Testing done
Screenshots
Jenkins 2.462.3 with the change:
Jenkins 2.479.2 with the change:
Submitter checklist