Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default pull request template #158

Merged

Conversation

MarkEWaite
Copy link
Contributor

Use default pull request template

The more detailed pull request template in this plugin has been ignored by most recent contributors to the plugin, including me. Let's use the default pull request template so that the template is consistent with the other templates used in Jenkins plugins.

This is consistent with the plugin archetype. It also relies on the default pull request template rather than providing its own pull request template.

No automated tests because this is a change to infrastructure, not to production code.

What has been done

  1. Removed the custom pull request template

How to test

  1. Create a pull request and confirm that the default Jenkins pull request template is used

Checklist

  • Git commits follow best practices
  • Build passes in Jenkins
  • Appropriate tests or explanation to why this change has no tests
  • Pull Request is marked with appropriate label (see .github/release-drafter.yml)
  • For dependency updates: links to external changelogs and, if possible, full diffs

The more detailed pull request template in this plugin has been ignored
by most recent contributors to the plugin, including me.  Let's use the
default pull request template so that the template is consistent with
the other templates used in Jenkins plugins.

This is consistent with the plugin archetype.  It also relies on the
default pull request template rather than providing its own pull request
template.
@MarkEWaite MarkEWaite added the chore General project maintenance label Jan 5, 2025
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mark. 👍

@gounthar gounthar enabled auto-merge (squash) January 5, 2025 12:52
@gounthar gounthar merged commit 189520c into jenkinsci:master Jan 5, 2025
17 checks passed
@MarkEWaite MarkEWaite deleted the use-default-pull-request-template branch January 6, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants