Require 2.452.4 and use API plugins #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.jenkins.io/doc/developer/plugin-development/dependency-management/#jenkins-core-bom says: > Jenkins core provides a Maven Bill Of Materials (BOM) that centrally > defines versions of various libraries used by Jenkins. If you are using > Maven to build your plugin, then you can simplify dependency management > by importing this BOM, at jenkins.version. Dependency versions are then > automatically synchronized with the version of Jenkins against which > you are building. Since commons-beanutils is included in the Jenkins core BOM, we can reference it as "provided" and since the Jenkins core BOM is now included, we can rely on the Jenkisn core BOM to manage the version of commons-beanutils. That seemed to resolve the upper bounds dependency error and let me learn more about the Jenkins core BOM. Testing done: * Tested with Jenkins 2.462.3 by creating a line plot that used a file named "plot-b.csv" with data that I added after each build. The plot was shown correctly when the plot was defined in the freestyle project as a post build action. * Tested with Jenkins 2.462.3 by creating a line plot as a build step and that failed with tip of the master branch and with the changes in this pull request. I don't know if that is a recent failure or if it has been there a long time. It has not been reported in the issue tracker.
MarkEWaite
approved these changes
Jan 5, 2025
|
Thanks. I think exclusion are still necessary. If not, the hpi will have transitive dependencies
This would reduce the hpi size and prevent unexpected runtime issue |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially automated. With current implementation, API plugins are added only when direct dependencies.
Since they are brought by opencsv it cause causing upper bound issue