add one param to set charset when read Properties file #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandell
requested changes
Mar 25, 2021
69bf86a to
35c44b8
Compare
rsandell
reviewed
Apr 16, 2021
| if(StringUtils.isEmpty(step.getEncoding())){ | ||
| properties.load(is); | ||
| } else { | ||
| properties.load( new BufferedReader(new InputStreamReader(is, step.getEncoding()))); |
There was a problem hiding this comment.
You need to close the streams or it will break things, especially on windows.
Something like above:
Suggested change
| properties.load( new BufferedReader(new InputStreamReader(is, step.getEncoding()))); | |
| try(InputStreamReader is = new InputStreamReader(is, step.getEncoding()); BufferedReader br = new BufferedReader(is)) { | |
| properties.load(br); | |
| } |
rsandell
requested changes
May 28, 2021
78a344d to
fb0f2c4
Compare
rsandell
reviewed
Nov 18, 2022
| </f:entry> | ||
| <f:entry title="${%interpolate.title}" field="interpolate" description="${%interpolate.description}"> | ||
| <f:checkbox /> | ||
| </f:entry> |
There was a problem hiding this comment.
added everything but the charset parameter?
Signed-off-by: bright.ma RMSH06 <bright.ma@blackshark.com>
or it will break things, especially on windows. Change-Id: Icc7a9a393d4fae9d546239f3545caf256f3a5b78 Signed-off-by: bright.ma <bright.ma@blackshark.com>
Keep the style same as WriteYamlStep
resources: update ReadPropertiesStep config.jelly for snippet generator
Change-Id: I5e2952cd3c4c92f7966bb7bc3be47a7042af27f3
fb0f2c4 to
de2145a
Compare
rsandell
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bright.ma RMSH06 bright.ma@blackshark.com
add one param to set charset when read Properties file