[JENKINS-54346] && [JENKINS-55505] Fix stream handling in tee (followup) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Homann <homann.philipp@googlemail.com>
jglick
approved these changes
Jun 15, 2020
| which is also guaranteeing backward compatibility when resuming after plug-in upgrade. | ||
| */ | ||
| transferredToRemote = Channel.current() != null; | ||
| oos.defaultWriteObject(); |
There was a problem hiding this comment.
In the original PR I suggested that this be rewritten to use writeReplace for legibility and maintainability, but I do not consider it a blocker.
src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/fs/TeeStep.java
Outdated
Show resolved
Hide resolved
| @Test | ||
| @Issue({"JENKINS-54346", "JENKINS-55505"}) | ||
| public void closed() throws Exception { | ||
| rr.then(r -> { |
There was a problem hiding this comment.
Still no test coverage of behavior across restarts that I can tell.
There was a problem hiding this comment.
See my last commit.
Is that what you expect?
There was a problem hiding this comment.
Something like that, yes. I would have to immerse myself in this patch for a while to really remember what the tricky cases were.
Signed-off-by: Philipp Homann <homann.philipp@googlemail.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a followup of #62
Most credits of changes going out to @tolnaisz
Just fixed the test error mentioned in #62