Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 2.440.3 or newer #261

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Require 2.440.3 or newer #261

merged 2 commits into from
Aug 20, 2024

Conversation

basil
Copy link
Member

@basil basil commented Jun 24, 2024

PCT caught a regression in the latest release, but only on the 2.426.x line:

java.lang.NoSuchMethodError: 'long org.apache.commons.io.IOUtils.skip(java.io.InputStream, long, java.util.function.Supplier)'
 at org.apache.commons.compress.utils.IOUtils.skip(IOUtils.java:282)
 at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextTarEntry(TarArchiveInputStream.java:409)
 at hudson.FilePath.readFromTar(FilePath.java:3081)
 at hudson.FilePath.copyRecursiveTo(FilePath.java:2866)
 at jenkins.model.StandardArtifactManager.archive(StandardArtifactManager.java:73)
 at org.jenkinsci.plugins.pipeline.utility.steps.CompressStepExecution.run(CompressStepExecution.java:109)
 at org.jenkinsci.plugins.pipeline.utility.steps.zip.ZipStepExecution.run(ZipStepExecution.java:64)
 at org.jenkinsci.plugins.pipeline.utility.steps.zip.ZipStepExecution.run(ZipStepExecution.java:51)
 at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
 at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
 at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
 at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
 at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
 at java.base/java.lang.Thread.run(Thread.java:840)
Finished: FAILURE

The root cause is that we're now compiling this plugin against the latest version of Commons Compress, but the version shipped in 2.426.x (1.13.0) is missing a method that is present in 1.14.0 or later. In the long term this type of issue will be resolved by removing Commons Compress from core. In the short term, require 2.440.3 or newer from this plugin to avoid offering this regression to users of older LTS lines.

Testing done

mvn clean verify -Dtest=InjectedTest

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the bug label Jun 24, 2024
@basil basil requested a review from a team as a code owner June 24, 2024 19:12
@rsandell rsandell merged commit ba9c03e into jenkinsci:master Aug 20, 2024
14 checks passed
@basil basil deleted the commons-io branch August 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants