Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh plugin for March 2023 #595

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Refresh plugin for March 2023 #595

merged 1 commit into from
Mar 23, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 14, 2023

Supersedes #587, #591, #593, and #594.

CC @car-roll

@basil
Copy link
Member Author

basil commented Mar 14, 2023

Used my admin powers to replay the build with the Jenkinsfile changes here: https://ci.jenkins.io/job/Plugins/job/pipeline-model-definition-plugin/job/PR-595/4/

Comment on lines +58 to +61
<systemPropertyVariables combine.children="append">
<!-- some of the AbstractModelDefTest’s run for a long time with @ClassRule JenkinsRule -->
<jenkins.test.timeout>600</jenkins.test.timeout>
</systemPropertyVariables>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this warning:

[INFO] --- surefire:3.0.0-M9:test (default-test) @ pipeline-model-definition ---
[WARNING] Parameter 'systemProperties' is deprecated: Use systemPropertyVariables instead.

Comment on lines -87 to -91
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>copyartifact</artifactId>
<version>1.46.4</version>
</dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided by the BOM so no longer needed.

@basil basil marked this pull request as draft March 15, 2023 02:08
@car-roll car-roll added the dependencies Pull requests that update a dependency file label Mar 15, 2023
@basil basil marked this pull request as ready for review March 22, 2023 22:46
@basil
Copy link
Member Author

basil commented Mar 22, 2023

@car-roll @olamy I have updated a test to be compatible with both Windows and Unix style line-breaks so that it works properly on our latest CI agents. I used my admin powers to replay the latest revision with the Jenkinsfile changes here: https://ci.jenkins.io/job/Plugins/job/pipeline-model-definition-plugin/job/PR-595/9/ The build is green. From my perspective this is ready to merge and release. Also note that this is needed for jenkinsci/plugin-compat-tester#489.

@jglick jglick added developer and removed dependencies Pull requests that update a dependency file labels Mar 23, 2023
@jglick jglick merged commit a31cb3b into jenkinsci:master Mar 23, 2023
@basil basil deleted the refresh branch March 23, 2023 00:22
@basil
Copy link
Member Author

basil commented Mar 23, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants