Merge pull request #122 from jglick/onFinalized

Make `BuildTriggerListener` wait for `onFinalized`, not just `onCompleted`
jenkinsci · Jul 28, 2023 · 5f0844d · 5f0844d
2 parents 03f799b + d38e0ec
commit 5f0844d
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerListener.java b/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerListener.java
@@ -1,6 +1,5 @@
 package org.jenkinsci.plugins.workflow.support.steps.build;
 
-import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.AbortException;
 import hudson.Extension;
 import hudson.console.ModelHyperlinkNote;
@@ -44,7 +43,7 @@ public void onStarted(Run<?, ?> run, TaskListener listener) {
     }
 
     @Override
-    public void onCompleted(Run<?,?> run, @NonNull TaskListener listener) {
+    public void onFinalized(Run<?,?> run) {
         for (BuildTriggerAction.Trigger trigger : BuildTriggerAction.triggersFor(run)) {
             if (!trigger.waitForStart) {
                 StepContext stepContext = trigger.context;