Adding method to return subtask map #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Find a way to access individual subtask metrics. Specifically, find a way to access individual subtask queue times.
While metrics currently has functionality to allow for time in queue information to be extracted from the general job, it does not have the functionality capable of extracting time in queue information from individual subtasks. We found that we desire to implement a feature within metrics that would retrieve the subtask times of our pipeline jobs, as the current metrics don't allow for accurate queue time tracking when you have parallelized tasks.
We accomplished this by returning a map that specifically maps each subtask in chronological order it entered the queue to the time it that each task spent waiting in queue.
Our modifications included one function in TimeInQueueAction.java: getSubTaskQueuingDurations()
getSubTaskQueuingDurations() makes a hash map that takes the subtask's relative order and maps it to the subtask queue time. Each subtask is given a number based on the order of when each one first entering the queue.