Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalise fonts #45

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Internalise fonts #45

merged 2 commits into from
Sep 9, 2022

Conversation

timbrown5
Copy link
Contributor

Generated internallised fonts using:
https://google-webfonts-helper.herokuapp.com/fonts/roboto?subsets=latin
https://google-webfonts-helper.herokuapp.com/fonts/roboto-mono?subsets=latin

Fixes: #9

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira

@timbrown5
Copy link
Contributor Author

From my (fairly light) local testing.

  • If I remove the 'src/main/webapp/resources/fonts' directory the browser resorts to Time New Roman:
    Screenshot 2022-09-09 at 15 43 46
    To me this shows that the fonts are picked up from that location

For reference here is the same page with that directory present.
Screenshot 2022-09-09 at 15 46 32

@timbrown5 timbrown5 requested a review from timja September 9, 2022 14:58
@timbrown5
Copy link
Contributor Author

@timja Sorry for dumping all the reviews on you (you were the suggested reviewer).

Is there anyone else who could/should be assigned?

@timja
Copy link
Member

timja commented Sep 9, 2022

@timja Sorry for dumping all the reviews on you (you were the suggested reviewer).

Is there anyone else who could/should be assigned?

you're the only maintainer so either you or if you have questions you could ping the @jenkinsci/sig-ux team

@timbrown5 timbrown5 merged commit e01ff83 into master Sep 9, 2022
@timbrown5 timbrown5 deleted the internalised_fonts branch September 12, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google font imports blocking UI on air gapped environments
2 participants