-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaged golang version to 1.19.1 #60
Conversation
I currently don't know of a great way to add the test - If the plugin still builds, is that sufficient? |
Filed this ticket in case it helps: https://issues.jenkins.io/browse/JENKINS-69776 |
Hi @ashmeer7 thanks for the PR!
We would actually need to test the incrementals generated here within the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would also need to bump golang in the windows versions as well
https://github.com/jenkinsci/lib-durable-task/blob/main/src/Dockerfile.windows
1.16 has multiple known vulnerabilities and at the very least trips up vulnerability scanners
3d70a4d
to
beafb11
Compare
Just did the update, ill have a follow up PR as soon as the incremental version builds. |
Downstream test: jenkinsci/durable-task-plugin#155 |
Looks like the tests passed. Is there anything else we need to look into? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@car-roll - Does this need to be released? Or can I just send this version down? |
@ashmeer7 it needs a release. I'm in the process of starting one. |
@ashmeer7 actually, feel free to update jenkinsci/durable-task-plugin#155 with this version |
This change updates the packaged golang version from 1.16 to 1.19.1. 1.16 has multiple known vulnerabilities which trips up vulnerability scanners. Updating to the latest golang version that is available at https://hub.docker.com/_/golang.
Once this is merged, I intend to upgrade the durable-task plugin with the new version.
Replaces #59