Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enforcement of generated binaries #12

Merged
merged 3 commits into from
May 24, 2021

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented May 21, 2021

Locally, whenever the unit tests fail in the dockerfile, the entire build fails. On CI, however, the build goes green. This adds an enforcer to make sure the required binary files have been generated.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@car-roll car-roll added the internal Changes that are not exposed to the user label May 21, 2021
@car-roll car-roll closed this May 21, 2021
@car-roll car-roll reopened this May 21, 2021
@car-roll car-roll force-pushed the add-enforcer-check branch from a8ccce3 to 325f876 Compare May 22, 2021 05:16
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert on Maven plugins, but this approach seems good to me.

@car-roll car-roll merged commit 739dc9e into jenkinsci:main May 24, 2021
@car-roll car-roll deleted the add-enforcer-check branch May 24, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes that are not exposed to the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants