Always define an explicit workspace volume, it defaults to an empty dir

[Vlatombe]

Should fix #600 (comment)

[jglick]

Not clear if you reproduced the bug in a test here—there are a couple of test patches but they just look like accommodating the change.

[Vlatombe]

@jglick Ideally it would need a html unit (since this is driven by the form UI) adding a pod template, saving then check that the resulting pod template has an empty dir volume. But I have no clue how to write it

[jglick]

adding a pod template, saving then check that the resulting pod template has an empty dir volume

So the opening of the relevant form and saving it are both routine things to do with a WebClient, and of course checking the state afterwards is easy. Clicking the button to add a new template and finding various text fields to fill in would be trickier, more low-level HtmlUnit stuff.

[Vlatombe]

Yes I agree about form handling, difficulty mostly lies in dealing with the weird add button

[jglick]

dealing with the weird add button

YUI, yes. https://github.com/jenkinsci/jenkins-test-harness/blob/1fe4b24633827a461921f2896fd2d450d7a78eb8/src/main/java/org/jvnet/hudson/test/JenkinsRule.java#L1573

[Vlatombe]

@jglick I think I have a working test, and I converted the repeatableHeteroProperty to repeatableProperty since PodTemplate is not designed to be extended anyway