[JENKINS-58767] Persist yaml fragment in a single string #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Aug 1, 2019
|
|
||
| private List<String> yamls = new ArrayList<>(); | ||
| /** | ||
| * List of yaml fragments used for transient pod templates. Never persisted |
There was a problem hiding this comment.
Could this field just be deleted, and any call to setYamls with a list of size > 1 would just set yaml to something separated by "\n----\n" or whatever? Would be easier to follow the logic and be sure that you are not missing some complication.
There was a problem hiding this comment.
hum, I guess it would increase complexity of getYaml, not sure I want it
There was a problem hiding this comment.
Problem I see is that would end up being an invalid yaml fragment to parse into a pod template
There was a problem hiding this comment.
As you see fit. I do not really understand what the list of YAMLs is for to begin with.
jglick
approved these changes
Aug 1, 2019
| @@ -96,6 +101,19 @@ public void upgradeFrom_1_15_9() { | |||
| assertNull(template._getYamls()); | |||
| } | |||
|
|
|||
| @Test | |||
| @LocalData | |||
| public void upgradeFrom_1_15_9_invalid() { | |||
Vlatombe
added a commit
to Vlatombe/kubernetes-plugin
that referenced
this pull request
Aug 28, 2019
…ct yaml is not null Amends jenkinsci#573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-58767