Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-57993] Verify no warnings are printed for a basic build #503

Merged
merged 13 commits into from
Oct 7, 2019
Merged

[JENKINS-57993] Verify no warnings are printed for a basic build #503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
56d1e48
[JENKINS-57993] Integration test to verify that no warnings are print…
jglick Jun 12, 2019
0b57163
Incremental deployment.
jglick Jun 13, 2019
ad084b6
Merge branch 'master' into quiet-JENKINS-57993
jglick Jun 13, 2019
454db5c
Picking up another core fix, and streaming the agent log where any Ab…
jglick Jun 13, 2019
eb8ac21
Merge branch 'master' into quiet-JENKINS-57993
jglick Jun 17, 2019
b171034
Merged into 2.181.
jglick Jun 17, 2019
5330793
Merge branch 'master' into quiet-JENKINS-57993
jglick Jul 2, 2019
1c4aefa
Merge branch 'master' into quiet-JENKINS-57993
jglick Jul 5, 2019
f09ce18
Merge branch 'master' into quiet-JENKINS-57993
jglick Sep 4, 2019
5a8e1de
Merge branch 'master' into quiet-JENKINS-57993
jglick Sep 25, 2019
87cd5e5
Update to LTS.
jglick Sep 25, 2019
58f52ed
Merge branch 'master' into quiet-JENKINS-57993
jglick Sep 27, 2019
45edbbe
Need to ensure we have trilead-api in test scope.
jglick Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<connectorHost />
<jenkins.host.address />
<java.level>8</java.level>
<jenkins.version>2.138.4</jenkins.version>
<jenkins.version>2.181-SNAPSHOT</jenkins.version> <!-- TODO https://github.com/jenkinsci/jenkins/pull/4066 -->
jglick marked this conversation as resolved.
Show resolved Hide resolved
<no-test-jar>false</no-test-jar>
<useBeta>true</useBeta>
<surefire.rerunFailingTestsCount>0</surefire.rerunFailingTestsCount>
Expand Down
19 changes: 12 additions & 7 deletions src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesPipelineTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
package org.csanchez.jenkins.plugins.kubernetes.pipeline;

import static org.csanchez.jenkins.plugins.kubernetes.KubernetesTestUtil.*;
import static org.hamcrest.Matchers.hasEntry;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;

import java.util.List;
Expand All @@ -49,6 +48,7 @@
import org.junit.rules.TemporaryFolder;
import org.jvnet.hudson.test.Issue;
import org.jvnet.hudson.test.JenkinsRuleNonLocalhost;
import org.jvnet.hudson.test.LoggerRule;

import hudson.model.Result;
import java.util.Locale;
Expand All @@ -64,20 +64,24 @@ public class KubernetesPipelineTest extends AbstractKubernetesPipelineTest {
@Rule
public TemporaryFolder tmp = new TemporaryFolder();

@Rule
public LoggerRule warnings = new LoggerRule();

WorkflowJob p;

WorkflowRun b;

@Before
public void setUp() throws Exception {
deletePods(cloud.connect(), getLabels(cloud, this, name), false);
logs.capture(1000);
warnings.record("", Level.WARNING).capture(1000);
p = r.jenkins.createProject(WorkflowJob.class, getProjectName());
p.setDefinition(new CpsFlowDefinition(loadPipelineScript(name.getMethodName() + ".groovy"), true));
b = p.scheduleBuild2(0).waitForStart();
assertNotNull(b);
}

@Issue("JENKINS-57993")
@Test
public void runInPod() throws Exception {
SemaphoreStep.waitForStart("podTemplate/1", b);
Expand All @@ -103,10 +107,6 @@ public void runInPod() throws Exception {
pods.getItems(), hasSize(1));
SemaphoreStep.success("pod/1", null);

for (String msg : logs.getMessages()) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very useful; left over from 23a0fce.

System.out.println(msg);
}

PodTemplate template = templates.get(0);
List<PodAnnotation> annotations = template.getAnnotations();
assertNotNull(annotations);
Expand All @@ -132,6 +132,11 @@ public void runInPod() throws Exception {
r.assertLogContains("script file contents: ", b);
assertFalse("There are pods leftover after test execution, see previous logs",
deletePods(cloud.connect(), getLabels(cloud, this, name), true));
assertThat("routine build should not issue warnings",
warnings.getRecords().stream().
filter(lr -> lr.getLevel().intValue() >= Level.WARNING.intValue()). // TODO .record(…, WARNING) does not accomplish this
map(lr -> lr.getSourceClassName() + "." + lr.getSourceMethodName() + ": " + lr.getMessage()).collect(Collectors.toList()), // LogRecord does not override toString
emptyIterable());
}

@Test
Expand Down