Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-35246] Test that Jenkins nodes are deleted after agent disconnection #201

Closed
wants to merge 2 commits into from
Closed

[JENKINS-35246] Test that Jenkins nodes are deleted after agent disconnection #201

wants to merge 2 commits into from

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Aug 17, 2017 •
edited
Loading

@carlossg carlossg changed the title [JENKINS-35246] Test that all jenkins nodes are deleted after tests [JENKINS-35246] Disconnect the node the first thing to ensure connection is gracefully closed Aug 25, 2017
@carlossg
Copy link
Contributor Author

Couldn't make the tests fail on minikube, will need to try on a real cluster, when #208 is merged

@marvinthepa
Copy link
Contributor

I guess you are not trying to get rid of this exception with this pr?:

Computer.threadPoolForRemoting [#7] for pod-test-0001-1ls04-v28xw terminated
java.nio.channels.ClosedChannelException
	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:208)
	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:222)
	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:832)
	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)

Because that one is still in the logs.

Also note that SlaveComputer.disconnect actually closes the connection asynchronously, so it might make sense to wait for the returned Future before continuing..

@carlossg
Copy link
Contributor Author

You are right, let's try waiting for a bit

@marvinthepa
Copy link
Contributor

marvinthepa commented Aug 25, 2017 •
edited
Loading

I actually meant calling waitget on the Future that is returned by Computer.disconnect.

But I tried that, and it doesn't get rid of the exception. As that is just a warning anyway, it's probably not a problem...

(edited)

@carlossg
Copy link
Contributor Author

wait is not what you think it is, it's Object.wait
get should wait for the disconnection to be finished

@carlossg
Copy link
Contributor Author

it's not a problem, just trying to gracefully end connection and avoid stacktraces in logs

@marvinthepa
Copy link
Contributor

wait is not what you think it is, it's Object.wait
get should wait for the disconnection to be finished

Sorry, that is what I meant. I was experimenting with get, but it didn't help with the exception.

@carlossg
Copy link
Contributor Author

Rebased on top of #248

@carlossg carlossg changed the title [JENKINS-35246] Disconnect the node the first thing to ensure connection is gracefully closed [JENKINS-35246] Test that Jenkins nodes are deleted after agent disconnection Dec 3, 2017
@carlossg
Copy link
Contributor Author

carlossg commented Dec 3, 2017

rebased

@jglick jglick mentioned this pull request May 28, 2019
Merged
@Vlatombe Vlatombe added the test Tests label Jul 6, 2019
@Vlatombe
Copy link
Member

Stale

@Vlatombe Vlatombe closed this Dec 23, 2020
@Vlatombe Vlatombe deleted the JENKINS-35246 branch February 17, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor403 trevor403 trevor403 approved these changes

@marvinthepa marvinthepa marvinthepa approved these changes

Assignees
No one assigned
Labels
test Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossg @marvinthepa @Vlatombe @trevor403