Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spotless #1478

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Enable spotless #1478

merged 5 commits into from
Dec 8, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Dec 7, 2023

Because too much style

To format existing code, run:

mvn spotless:apply

Testing done

Submitter checklist

Preview Give feedback

@Vlatombe Vlatombe added the chore Maintenance label Dec 7, 2023
@Vlatombe Vlatombe requested a review from a team as a code owner December 7, 2023 09:00
@jglick
Copy link
Member

jglick commented Dec 7, 2023

Flake?

org.awaitility.core.ConditionTimeoutException: org.csanchez.jenkins.plugins.kubernetes.pipeline.KubernetesPipelineTest expected a collection with size <1> but collection size was <2> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at org.csanchez.jenkins.plugins.kubernetes.pipeline.KubernetesPipelineTest.dynamicPVCVolume(KubernetesPipelineTest.java:771)

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vlatombe Vlatombe enabled auto-merge (squash) December 8, 2023 09:06
@Vlatombe Vlatombe marked this pull request as draft December 8, 2023 13:57
auto-merge was automatically disabled December 8, 2023 13:57

Pull request was converted to draft

@Vlatombe Vlatombe marked this pull request as ready for review December 8, 2023 14:51
@Vlatombe Vlatombe mentioned this pull request Dec 8, 2023
@Vlatombe
Copy link
Member Author

Vlatombe commented Dec 8, 2023

Partly split to #1480

@Vlatombe Vlatombe enabled auto-merge (squash) December 8, 2023 15:48
@Vlatombe Vlatombe merged commit 9c1d58d into jenkinsci:master Dec 8, 2023
5 checks passed
@jglick
Copy link
Member

jglick commented Dec 8, 2023

Remember to add 9c1d58d to the ignore list for blame.

@Vlatombe
Copy link
Member Author

Vlatombe commented Dec 8, 2023

Done in 808c05a

@Vlatombe Vlatombe deleted the enable-spotless branch December 8, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants