Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix KubernetesCloudTest as configuration page was moved #1415

Conversation

Pldi23
Copy link
Contributor

@Pldi23 Pldi23 commented Aug 14, 2023

Hi kubernetes plugin maintainers!
Please review KubernetesCloudTest fix. In jenkins 2.414 configuration page for kubernetes was moved, so 2 tests start failing. This PR fixes the issue.

Testing done

Submitter checklist

Preview Give feedback

@Pldi23 Pldi23 requested a review from a team as a code owner August 14, 2023 10:52
@jglick jglick merged commit 019844f into jenkinsci:master Aug 14, 2023
@Pldi23
Copy link
Contributor Author

Pldi23 commented Aug 15, 2023

@jglick would you mind releasing this? (To fix PCT)

@jglick
Copy link
Member

jglick commented Aug 15, 2023

https://github.com/jenkinsci/kubernetes-plugin/releases/tag/3995.v227c16b_675ee

Vlatombe added a commit to Vlatombe/kubernetes-plugin that referenced this pull request Aug 16, 2023
Use a more explicit check and add todos to clean up for later.

Verified with

```
mvn test -Dtest=KubernetesCloudTest -Djenkins.version=2.414
```
@Vlatombe Vlatombe mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants