feat: system property to disable no delay provisioner cloud shuffle #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
reviewed
Jul 4, 2023
Comment on lines
65
to
72
| searchClouds: | ||
| for (Cloud cloud : jenkinsClouds) { | ||
| int workloadToProvision = currentDemand - availableCapacity; | ||
| if (!(cloud instanceof KubernetesCloud)) continue; | ||
| if (!cloud.canProvision(cloudState)) continue; | ||
| for (CloudProvisioningListener cl : CloudProvisioningListener.all()) { | ||
| if (cl.canProvision(cloud, cloudState, workloadToProvision) != null) { | ||
| continue; | ||
| continue searchClouds; |
There was a problem hiding this comment.
For clarity, could you split this to a different PR (since it is a minor bug) ?
Add system property `io.jenkins.plugins.kubernetes.NoDelayProvisionerStrategy.disableCloudShuffle` to disable randomizing the cloud list. When disabled clouds are search in the order they are defined making for more predicable pod template selection.
64eea2f to
d4d257f
Compare
Vlatombe
approved these changes
Jul 6, 2023
|
I struggle to understand why it would ever be shuffled. #598 (comment) suggests that the default behavior is intended as some sort of load balancing? |
The problem arises as soon as you do not specify instance caps but rely on cpu/memory requests of the pods, so the cloud could spawn infinite pods, then every pod is created on the first cloud, the pod will end up in pending state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add system property
io.jenkins.plugins.kubernetes.NoDelayProvisionerStrategy.disableCloudShuffleto disable randomizing the cloud list. When disabled clouds are search in the order they are defined making for more predicable pod template selection.The use case for disabling is for multi-cloud environments where templates in both clouds share common labels and predictable cloud and pod template selection is desired. For example the first cloud is preferred and the second cloud is a backup, say for when the instance cap is hit.
Testing done
Tested in live environment
Submitter checklist