Seed jobs can not clone repositories which contain lfs files.

[rcosnita]

Expected Behavior

The seed job should correctly be configured to provide credentials also to the git lfs process.

Actual Behavior

When the seed job is cloning the repository indicated in the seedJob configuration it fails with Smudge error: Error downloading.

Steps to Reproduce the Problem

1. Create a private git repository.
2. Add some lfs files into it.
3. Configure the seedJob in jenkins CRD so that it points to the newly created private repository.
4. Deploy the new jenkins instance.

Additional Info

• Kubernetes version

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-13T11:52:32Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.12-eks-31566f", GitCommit:"31566f851673e809d4d667b7235ed87587d37722", GitTreeState:"clean", BuildDate:"2020-10-20T23:25:14Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"linux/amd64"}

• Jenkins Operator version:

v0.4.0

[rcosnita]

The easies way to fix this issue IMHO is to enable the GIT LFS after checkout behavior build wrapper populated with the secret specified for the seedJob (if any available).

I think the code from https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/configuration/user/seedjobs/seedjobs.go should be changed in function: seedJobGroovyScriptTemplate

I will try to open a PR with the fix for this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue is still affecting you, just comment with any updates and we'll keep it open. Thank you for your contributions.