Revert "Update core/src/main/java/hudson/model/View.java"

This reverts commit 5aaba6f.

core/src/main/java/hudson/model/View.java

@@ -678,188 +678,187 @@
      */
     @RequirePOST
     public synchronized void doSubmitDescription(StaplerRequest2 req, StaplerResponse2 rsp) throws IOException, ServletException {
         if (Util.isOverridden(View.class, getClass(), "doSubmitDescription", StaplerRequest.class, StaplerResponse.class)) {
             try {
                 doSubmitDescription(StaplerRequest.fromStaplerRequest2(req), StaplerResponse.fromStaplerResponse2(rsp));
             } catch (javax.servlet.ServletException e) {
                 throw ServletExceptionWrapper.toJakartaServletException(e);
             }
         } else {
             doSubmitDescriptionImpl(req, rsp);
         }
     }
 
     /**
      * @deprecated use {@link #doSubmitDescription(StaplerRequest2, StaplerResponse2)}
      */
     @Deprecated
     @StaplerNotDispatchable
     public synchronized void doSubmitDescription(StaplerRequest req, StaplerResponse rsp) throws IOException, javax.servlet.ServletException {
         doSubmitDescriptionImpl(StaplerRequest.toStaplerRequest2(req), StaplerResponse.toStaplerResponse2(rsp));
     }
 
     private void doSubmitDescriptionImpl(StaplerRequest2 req, StaplerResponse2 rsp) throws IOException {
         checkPermission(CONFIGURE);
 
         description = req.getParameter("description");
         save();
         rsp.sendRedirect(".");  // go to the top page
     }
 
     /**
      * Accepts submission from the configuration page.
      *
      * Subtypes should override the {@link #submit(StaplerRequest2)} method.
      */
     @POST
     public final synchronized void doConfigSubmit(StaplerRequest2 req, StaplerResponse2 rsp) throws IOException, ServletException, FormException {
         checkPermission(CONFIGURE);
 
         submit(req);
 
         var json = req.getSubmittedForm();
         setDescription(json.optString("description"));
         setFilterExecutors(json.optBoolean("filterExecutors"));
         setFilterQueue(json.optBoolean("filterQueue"));
         rename(req.getParameter("name"));
 
         getProperties().rebuild(req, json, getApplicablePropertyDescriptors());
 
         save();
 
         FormApply.success("../" + Util.rawEncode(name)).generateResponse(req, rsp, this);
     }
 
     /**
      * Handles the configuration submission.
      *
      * Load view-specific properties here.
      */
     protected /* abstract */ void submit(StaplerRequest2 req) throws IOException, ServletException, FormException {
         if (Util.isOverridden(View.class, getClass(), "submit", StaplerRequest.class)) {
             try {
                 submit(StaplerRequest.fromStaplerRequest2(req));
             } catch (javax.servlet.ServletException e) {
                 throw ServletExceptionWrapper.toJakartaServletException(e);
             }
         } else {
             throw new AbstractMethodError("The class " + getClass().getName() + " must override at least one of the "
                     + View.class.getSimpleName() + ".submit methods");
         }
     }
 
     /**
      * @deprecated use {@link #submit(StaplerRequest2)}
      */
     @Deprecated
     protected void submit(StaplerRequest req) throws IOException, javax.servlet.ServletException, FormException {
         if (Util.isOverridden(View.class, getClass(), "submit", StaplerRequest2.class)) {
             try {
                 submit(StaplerRequest.toStaplerRequest2(req));
             } catch (ServletException e) {
                 throw ServletExceptionWrapper.fromJakartaServletException(e);
             }
         } else {
             throw new AbstractMethodError("The class " + getClass().getName() + " must override at least one of the "
                     + View.class.getSimpleName() + ".submit methods");
         }
     }
 
 
     /**
      * Deletes this view.
      */
     @RequirePOST
     public synchronized void doDoDelete(StaplerRequest2 req, StaplerResponse2 rsp) throws IOException, ServletException {
         checkPermission(DELETE);
 
         owner.deleteView(this);
 
         rsp.sendRedirect2(req.getContextPath() + "/" + owner.getUrl());
     }
 
 
     /**
      * Creates a new {@link Item} in this collection.
      *
      * <p>
      * This method should call {@link ModifiableItemGroup#doCreateItem(StaplerRequest2, StaplerResponse2)}
      * and then add the newly created item to this view.
      *
      * @return
      *      null if fails.
      * @since TODO
      */
-    @StaplerNotDispatchable
     public /* abstract */ Item doCreateItem(StaplerRequest2 req, StaplerResponse2 rsp) throws IOException, ServletException {
         if (Util.isOverridden(View.class, getClass(), "doCreateItem", StaplerRequest.class, StaplerResponse.class)) {
             try {
                 return doCreateItem(StaplerRequest.fromStaplerRequest2(req), StaplerResponse.fromStaplerResponse2(rsp));
             } catch (javax.servlet.ServletException e) {
                 throw ServletExceptionWrapper.toJakartaServletException(e);
             }
         } else {
             throw new AbstractMethodError("The class " + getClass().getName() + " must override at least one of the "
                     + View.class.getSimpleName() + ".doCreateItem methods");
         }
     }
 
     /**
      * @deprecated use {@link #doCreateItem(StaplerRequest2, StaplerResponse2)}
      */
     @Deprecated
     @StaplerNotDispatchable
     public Item doCreateItem(StaplerRequest req, StaplerResponse rsp) throws IOException, javax.servlet.ServletException {
         if (Util.isOverridden(View.class, getClass(), "doCreateItem", StaplerRequest2.class, StaplerResponse2.class)) {
             try {
                 return doCreateItem(StaplerRequest.toStaplerRequest2(req), StaplerResponse.toStaplerResponse2(rsp));
             } catch (ServletException e) {
                 throw ServletExceptionWrapper.fromJakartaServletException(e);
             }
         } else {
             throw new AbstractMethodError("The class " + getClass().getName() + " must override at least one of the "
                     + View.class.getSimpleName() + ".doCreateItem methods");
         }
     }
 
     /**
      * Makes sure that the given name is good as a job name.
      * For use from {@code newJob}.
      */
     @Restricted(DoNotUse.class) // called from newJob view
     public FormValidation doCheckJobName(@QueryParameter String value) {
         // this method can be used to check if a file exists anywhere in the file system,
         // so it should be protected.
         getOwner().checkPermission(Item.CREATE);
 
         if (Util.fixEmpty(value) == null) {
             return FormValidation.ok();
         }
 
         try {
             Jenkins.checkGoodName(value);
             value = value.trim(); // why trim *after* checkGoodName? not sure, but ItemGroupMixIn.createTopLevelItem does the same
             ItemGroup<?> parent = getOwner().getItemGroup();
             Jenkins.get().getProjectNamingStrategy().checkName(parent.getFullName(), value);
         } catch (Failure e) {
             return FormValidation.error(e.getMessage());
         }
 
         if (getOwner().getItemGroup().getItem(value) != null) {
             return FormValidation.error(Messages.Hudson_JobAlreadyExists(value));
         }
 
         // looks good
         return FormValidation.ok();
     }
 
     /**
      * An API REST method to get the allowed {$link TopLevelItem}s and its categories.
      *
      * @return A {@link Categories} entity that is shown as JSON file.
      */
     @Restricted(DoNotUse.class)
     public Categories doItemCategories(StaplerRequest2 req, StaplerResponse2 rsp, @QueryParameter String iconStyle) throws IOException, ServletException {
         getOwner().checkPermission(Item.CREATE);
 
         rsp.addHeader("Cache-Control", "no-cache, no-store, must-revalidate");