Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an old m2e configuration #9522

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

timja
Copy link
Member

@timja timja commented Aug 3, 2024

See JENKINS-XXXXX.

Noticed in #9459 renovate was complaining about not being able to resolve this package which led to a long rabbithole.

Renovate already ignores org.maven.eclipse:lifecycle-mapping as lots of projects have that. I could only find Jenkins and one other project that use this dependency and no information on it. It was added in 2010 in a large commit: c85e60f

I'm guessing its unused, and we can always revert it and ignore it in renovate if needed.

Any thoughts?

Testing done

Proposed changelog entries

  • human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@timja timja added the skip-changelog Should not be shown in the changelog label Aug 3, 2024
@timja timja requested a review from a team August 3, 2024 15:44
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja
Copy link
Member Author

timja commented Aug 7, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 7, 2024
@basil basil merged commit 8dd2a33 into jenkinsci:master Aug 7, 2024
15 checks passed
@timja timja deleted the remove-legacy-m2e-config branch August 10, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants