[JENKINS-73453] make icons in table buttons resizable #9482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #9131 the css class
jenkins-table__button
was replaced at certain places withjenkins-button
. But this change caused regressions:Before:
![image](https://private-user-images.githubusercontent.com/17767050/350127707-505c6910-e740-4109-a824-47ac921548ed.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDA2MjAsIm5iZiI6MTczOTcwMDMyMCwicGF0aCI6Ii8xNzc2NzA1MC8zNTAxMjc3MDctNTA1YzY5MTAtZTc0MC00MTA5LWE4MjQtNDdhYzkyMTU0OGVkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMDUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjMGE3OTljOGIxMzY3ZDI5NmQ2MzAyN2QyMDEzZDdkNWI4NTQ5YzdmNTQ1NTAwZGEyYmRiODMzMTU3Y2QwYjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GKBYOxmda-gHXlImsIicY07V0N924k6ksC9dFS8EvjE)
![image](https://private-user-images.githubusercontent.com/17767050/350127784-abbd0967-f5c4-4e7a-ae4f-8f11155f5d09.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDA2MjAsIm5iZiI6MTczOTcwMDMyMCwicGF0aCI6Ii8xNzc2NzA1MC8zNTAxMjc3ODQtYWJiZDA5NjctZjVjNC00ZTdhLWFlNGYtOGYxMTE1NWY1ZDA5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMDUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVmN2JhYTA3Zjk5NThkYzExOWUyMWUyMzA0NzdmNGZjY2VkMWZhZWE2ZDljYzRkZGU0Nzg3OTI5ODlkNGQ3ODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.3lBsYZUKydbZpd_xvi7BjtTp5lB-2xrDfUeXuegWIZg)
![image](https://private-user-images.githubusercontent.com/17767050/350127866-401512cb-e617-4923-8200-70cb2cbaafa8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDA2MjAsIm5iZiI6MTczOTcwMDMyMCwicGF0aCI6Ii8xNzc2NzA1MC8zNTAxMjc4NjYtNDAxNTEyY2ItZTYxNy00OTIzLTgyMDAtNzBjYjJjYmFhZmE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMDUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFkZDU2NTJjODdiZDk0ZDczOGJhNDdkMjY0ZDc5ZGM5NjhiYzMyYTJlZmZjOWEzZWYwMGM4ZjRiYjZkN2UwMjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Lb5gJ4hYz8jaY3m2hl4oX5OixdWfPr-MPlWL4YNvQIo)
After:
![image](https://private-user-images.githubusercontent.com/17767050/350128649-34230101-2b71-4f66-904c-74b656eb07d3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDA2MjAsIm5iZiI6MTczOTcwMDMyMCwicGF0aCI6Ii8xNzc2NzA1MC8zNTAxMjg2NDktMzQyMzAxMDEtMmI3MS00ZjY2LTkwNGMtNzRiNjU2ZWIwN2QzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMDUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYyZmFhMTQ1YzY3OTQxZGI2MGU5YTFjOWQ4NGJjMDI1NDc3YWYzNTA0NjgzZTZkOWY4NjZkY2U5ZjY3NDAzM2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Sv0bt9F_KnomIPFULUZ-rIZzkOfxjhuxGs9Z8-eOWBo)
![image](https://private-user-images.githubusercontent.com/17767050/350128744-d1361e03-d054-4b59-b5f4-795b2b656654.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDA2MjAsIm5iZiI6MTczOTcwMDMyMCwicGF0aCI6Ii8xNzc2NzA1MC8zNTAxMjg3NDQtZDEzNjFlMDMtZDA1NC00YjU5LWI1ZjQtNzk1YjJiNjU2NjU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMDUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1MzIzZGJlZWQ4NjE2MjFhZjJjYTFjNGI0OGMzODkxMDE3ODUxNjg2NTM1MjkwMGYyZDNlYzdiZDYxOTlkNDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gl2sQtHHnESDFHfndwVkwDvTR5WUz9uwZsETMQtuY2Y)
![image](https://private-user-images.githubusercontent.com/17767050/350128833-dbc6f2e4-70a9-427f-ac1b-a26f33404814.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MDA2MjAsIm5iZiI6MTczOTcwMDMyMCwicGF0aCI6Ii8xNzc2NzA1MC8zNTAxMjg4MzMtZGJjNmYyZTQtNzBhOS00MjdmLWFjMWItYTI2ZjMzNDA0ODE0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDEwMDUyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2NGU2MjZlODBmOGVlOTBmNzY0NTUxOTE2YTczMjQ5Y2I5N2IyOTE3MzQ0Y2M5ZGQ0N2I3MmM2M2MzZDRiODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hHPYILEBhjjIHE3Bo8Ks-PNNDIm33hffwtNV-fZrZJU)
This change restores the old icon size for large tables and adds additional css rules for jenkins-button inside tables so they are properly resized and the padding is correct
See JENKINS-73453.
Testing done
Manual testing
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist