-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70822] Improve plugin manager search #9137
Open
timja
wants to merge
4
commits into
jenkinsci:master
Choose a base branch
from
timja:JENKINS-70822-search-tokens
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
added
the
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
label
Apr 6, 2024
Was already in used but access modifier checks mustn't work in a lambda
github-actions
bot
added
the
unresolved-merge-conflict
There is a merge conflict with the target branch.
label
Apr 18, 2024
Please take a moment and address the merge conflicts of your pull request. Thanks! |
A1exKH
suggested changes
Jan 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, resolve merge conflicts for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
unresolved-merge-conflict
There is a merge conflict with the target branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-70822.
Consider multiple words rather than just doing sub string match
build token can now match build-token-root
Pipeline Groovy, can now match Pipeline: Groovy.
I had to implement a basic ranking algorithm in order for this to be usable as without it they appeared in the middle somewhere or even not in first 50 in some cases.
I restricted the multiple word search to just name and title as a lot of these words show up in the description.
Open to feedback :)
Testing done
Unit tests + searches in the UI especially the searches from the Jira ticket
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist