Bump Mina to 2.12.1 in the CLI

[daniel-beck]

Upstream release notes: https://github.com/apache/mina-sshd/releases

Explanation why this is filed manually: jenkins-infra/helpdesk#3919 (comment)

Testing done

None, pretend I am Dependabot (just without as many links).

Proposed changelog entries

• Update Apache Mina in the CLI from 2.11.0 to 2.12.1.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[yaroslavafenkin]

Do we care about these?

jenkins/war/pom.xml

Lines 522 to 535 in 9970349

	<artifactItem>
	<!-- dependency of mina-sshd-api-core and sshd -->
	<groupId>io.jenkins.plugins.mina-sshd-api</groupId>
	<artifactId>mina-sshd-api-common</artifactId>
	<version>2.11.0-86.v836f585d47fa_</version>
	<type>hpi</type>
	</artifactItem>
	<artifactItem>
	<!-- dependency of sshd -->
	<groupId>io.jenkins.plugins.mina-sshd-api</groupId>
	<artifactId>mina-sshd-api-core</artifactId>
	<version>2.11.0-86.v836f585d47fa_</version>
	<type>hpi</type>
	</artifactItem>

[MarkEWaite]

The API plugin has been released with 2.12.1. Pull request:

• Use Apache Mina 2.12.1 mina-sshd-api-plugin#92

API release 2.12.1-101.v85b_e08b_780dd

[daniel-beck]

Do we care about these?

These are bundled as a dependency of the split sshd plugin. It's fairly rare for these bundled plugins to be used, most scenarios install whatever is latest from update sites. So we do care, just not as much. Plus, Dependabot knows how to update these.

[MarkEWaite]

Tested by building Jenkins core with pull requests #9093, #9097. and #9089 then removed the Ignore annotation from LoadDetachedPluginsTest.noUpdateSiteWarnings() and ran that test with:

mvn clean verify -Dtest=jenkins.install.LoadDetachedPluginsTest,jenkins.model.StartupTest

Tested by including Apache Mina sshd common 2.12.1-101.v85b_e08b_780dd and Apache Mina sshd core 2.12.1-101.v85b_e08b_780dd releases in the plugins.txt file of my Jenkins controller and running that controller with agents connected through ssh to Debian 10, Debian 11, Debian 12, Debian testing, Debian unstable, FreeBSD 13.1, Red Hat Enterprise Linux 8, Rocky Linux 9, Ubuntu 20.04, Ubuntu 22.04, and Windows 11,

Tested by running Jenkins with those pull requests and connecting to the command line interface that I configured to use the fixed port 44022 with an RSA ssh private key and the ssh server plugin. After registering my RSA public key with my account on the Jenkins controller, I was able to perform a quiet-down command over ssh with the command:

ssh -i ~/.ssh/id_rsa -p 44022 test-host quiet-down

[MarkEWaite]

Thanks!