-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backporting for LTS 2.440.2 #9014
Backporting for LTS 2.440.2 #9014
Conversation
* [JENKINS71148] avoid empty tooltips when the tooltip or html tooltip is empty or whitespace only it is avoided that the tippy is invoked at all which would otherwise just display a small but empty element. * better null checks (cherry picked from commit 0675943)
…time trend views (jenkinsci#8966) [JENKINS-72711] Restore progress animation in build history and build time trend views Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> (cherry picked from commit f91d1ec)
@krisstern can you confirm whether
is the same as what's mentioned in the 2.440.1 backporting? I ask because the empty folder icons were included in the last LTS changelog. I just want to make sure that it is included in the correct changelog, so if it did not get released as part of .1, then I need to adjust everything accordingly. |
@kmartens27 Yes, the commit referring to in JENKINS-72407 Major <a href="https://www.jenkins.io/changelog/?query#v2.443">https://www.jenkins.io/changelog/?query#v2.443</a>
Build status icon missing for multibranch pipeline
https://issues.jenkins.io/browse/JENKINS-72407 is an empty commit. Should be okay codewise. However, I am not sure if this is needed. I am including this resolved commit again for completeness' sake, so that we can close the JIRA issue for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for JENKINS-72407 was already backported to stable-2.440
in #8945. I do not see a need for an empty commit, as this feels like process for its own sake rather than for the sake of achieving any specific goal. But I do not feel strongly either way.
I changed the Jira labels from |
fb1a323
to
57ab550
Compare
I have removed the commit for: JENKINS-72407 Major <a href="https://www.jenkins.io/changelog/?query#v2.443">https://www.jenkins.io/changelog/?query#v2.443</a>
Build status icon missing for multibranch pipeline
https://issues.jenkins.io/browse/JENKINS-72407 |
Submitter checklist
Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist