Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72679] Revert #8791 #8956

Closed
wants to merge 2 commits into from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Feb 13, 2024

See JENKINS-72679.

#8941 attempted to address problems introduced in #8791, but introduces visual artifacts (addressed in #8954) and still leaves behind active UI elements.

Seems easier at this point to revert the culprit and start over, especially if we want a solution for 2.440.1.

Testing done

Revert PR, we're just going back in time. Opened and closed admin monitor, checked the link didn't remain clickable after the popup was closed.

Proposed changelog entries

  • Revert changes to the appearance of the administrative monitors popup in 2.440 due to problems.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@NotMyFault
Copy link
Member

Does #8954 address your open concerns?
And if not, do you think it's easier to merge this PR reverting the change altogether and backporting the reversal to 2.440.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants