Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71406] Flake in NodeCanTakeTaskTest.becauseNodeIsBusy #8115

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 9, 2023

See JENKINS-71406. Similar to #8068, adapting to jenkinsci/jenkins-test-harness#198, though a more straightforward fix in this case: the test was indeed scheduling two builds and aborting and waiting for the first to complete, but neglected to do the same for the second before exiting.

Testing done

Just checked that it passed locally; did not observe a local failure. Test output with fix does show it aborting build 2, matching flake error message. Saw a flake in trunk recently: https://github.com/jenkinsci/jenkins/runs/14057889710

Proposed changelog entries

  • N/A

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jun 10, 2023
@NotMyFault NotMyFault requested a review from a team June 10, 2023 09:52
@timja timja merged commit f22f25c into jenkinsci:master Jun 10, 2023
@jglick jglick deleted the NodeCanTakeTaskTest-JENKINS-71406 branch June 10, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants