-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the security warnings popup, show recommended actions #7046
Conversation
core/src/main/resources/jenkins/security/UpdateSiteWarningsMonitor/message.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update on it. I imagine the recommendation to uninstall the plugin without a fix is "sufficient" to be in written format like this 👍
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. |
This adds information about the (un)availability of fixes to the security warning popup.
The warnings are changed into an inner class to have a reference to the related update site to check whether an update fixing the issue is being offered. We're not bothering with understanding the semantics of plugin updates offered across different update sites here, which might be the correct thing to do or not, unsure. I expect this is very unusual, so we have very little data to reason about the optimal behavior, and it's probably not worth the time either.
Screenshot:
Before
After
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
if applicable.eval
to ease future introduction of Content-Security-Policy directives (see documentation on jenkins.io).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).