[JENKINS-51913] Prevent archiveArtifacts from displaying a stack trace when no artifacts are found

[gregswift]

Re-implementation of #4913
See JENKINS-51913.

Testing

Added a test to validate that there isn't a stack trace, and that the error is present.

Proposed changelog entries

Do not print a stack trace when archiveArtifact does not find a file.

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• (n/a) For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@basil @jackgene

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Misc

Shout out to @adrianjgeorge for helping me out :D

[gregswift]

thanks @basil for the assist on the errors in the test.

[basil]

Thanks for the PR!

[basil]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

[jglick]

Thanks! I saw the ping a couple weeks ago but just did not have time to dig in.

[jglick]

Or more directly could do something along the lines of

assertThat("No stacktrace shown", build.getLog(), not(containsString("\tat ")));

[basil]

But then that would be inconsistent with other code in this file.