Fixed testparamter in ZipArchiverTest

[StefanSpieker]

I stumbled upon a minor issue I thought, but this might be a real bug in the implementation. The existing txt file was just 2 bytes big, instead of 4gb +2. As soon as I corrected this, the test fails.

The PR introducing this functionality was: #3536

Proposed changelog entries

• TBD

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jsoref

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[StefanSpieker]

I tried setting the to Zip64Mode.Always which fixed the writing part but broke the reading ...

[jsoref]

Off-topic, you're missing a letter near: paramter.

But, is this just converting a broken test into a failing test as opposed to actually getting the system to pass?

(Thanks for spotting it either way... "oops" on my part.)

[jsoref]

This:

jenkins/core/src/test/java/hudson/util/io/ZipArchiverTest.java

Line 66 in 360029e

archiver = new ZipArchiver(Files.newOutputStream(zipFile.toPath()));

... probably should be a ZipOutputStream, as in:

jenkins/core/src/test/java/hudson/PluginManagerTest.java

Line 158 in dcc9a92

try(ZipOutputStream out = new ZipOutputStream(Files.newOutputStream(f.toPath()))) {

[StefanSpieker]

I'm not really sure if the test is broken or the code is not working. Are you sure the code works?

[MRamonLeon]

Indeed, maybe we need to fix the feature

[MRamonLeon]

That's right, System.out.println(4 * 1024 * 1024 * 1024 + 2); prints 2
The file used is indeed 2 bytes length.

@oleg-nenashev maybe this is affecting here:
https://commons.apache.org/proper/commons-compress/javadocs/api-1.18/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#setUseZip64-org.apache.commons.compress.archivers.zip.Zip64Mode-

When setting the mode to AsNeeded, Zip64 extensions will transparently be used for those entries that require them. This mode can only be used if the uncompressed size of the ZipArchiveEntry is known when calling putArchiveEntry(org.apache.commons.compress.archivers.ArchiveEntry) or the archive is written to a seekable output (i.e. you have used the File-arg constructor) - this mode is not valid when the output stream is not seekable and the uncompressed size is unknown when putArchiveEntry(org.apache.commons.compress.archivers.ArchiveEntry) is called.

The CI failure:

SEVERE: exception driving ZipArchiver
org.apache.tools.zip.Zip64RequiredException: huge64bitFileTest.txt's size exceeds the limit of 4GByte.
	at org.apache.tools.zip.ZipOutputStream.checkIfNeedsZip64(ZipOutputStream.java:659)
	at org.apache.tools.zip.ZipOutputStream.handleSizesAndCrc(ZipOutputStream.java:640)
	at org.apache.tools.zip.ZipOutputStream.closeEntry(ZipOutputStream.java:553)
	at hudson.util.io.ZipArchiver.visit(ZipArchiver.java:83)
	at hudson.util.io.ZipArchiverTest.huge64bitFile(ZipArchiverTest.java:121)

[MRamonLeon]

avoid adding unrelated changes to your PR

[jsoref]

Fwiw, here's what I have:
jsoref@509a2a1

I looked into the other side and stopped.