Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the interface of Jenkins CLI #10143

Merged
merged 15 commits into from
Jan 15, 2025
Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 10, 2025

Medium PR to refresh the interface of Jenkins CLI.

What's changed?

  • Help link has been moved to the app bar - consistent with other settings pages
  • Instructions have been tidied up, converted to a numbered list with a large call to action button
  • Side-panel has been dropped, consistent with other settings pages
  • Snippet is now copyable

Before
image

After
image

Testing done

  • Copying works
  • Help link works
  • Commands still link as expected

Proposed changelog entries

  • Refresh the interface of Jenkins CLI page

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik requested a review from a team January 10, 2025 12:09
@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 10, 2025
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@krisstern krisstern requested a review from a team January 12, 2025 09:35
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janfaracik LGTM.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 14, 2025
@krisstern krisstern merged commit f9d0f62 into jenkinsci:master Jan 15, 2025
16 checks passed
@janfaracik janfaracik deleted the revamp-cli branch January 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants