control the presence of the abort icon based on permission.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6579 71c3de6d-444a-0410-be80-ed276b4c234a
jenkinsci · Jan 12, 2008 · e260817 · e260817
1 parent 5edc0f1
commit e260817
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/core/src/main/java/hudson/model/AbstractBuild.java b/core/src/main/java/hudson/model/AbstractBuild.java
@@ -586,11 +586,8 @@ public List<AbstractBuild> getBuilds() {
         }
     }
 
-    /**
-     * People can stop a build if they can start a build.
-     */
     public void checkAbortPermission() {
-        getParent().getACL().checkPermission(AbstractProject.BUILD);
+        getParent().getACL().checkPermission(AbstractProject.ABORT);
     }
 
 //

diff --git a/core/src/main/java/hudson/model/AbstractProject.java b/core/src/main/java/hudson/model/AbstractProject.java
@@ -937,4 +937,8 @@ public int compare(Integer o1, Integer o2) {
     private static final Logger LOGGER = Logger.getLogger(AbstractProject.class.getName());
 
     public static final Permission BUILD = new Permission(PERMISSIONS, "Build", Permission.UPDATE);
+    /**
+     * Permission to abort a build. For now, let's make it the same as {@link #BUILD}
+     */
+    public static final Permission ABORT = BUILD;
 }
diff --git a/core/src/main/java/hudson/model/Executor.java b/core/src/main/java/hudson/model/Executor.java
@@ -8,6 +8,7 @@
 
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
+import org.acegisecurity.AccessDeniedException;
 
 
 /**
@@ -162,6 +163,18 @@ public void doStop( StaplerRequest req, StaplerResponse rsp ) throws IOException
         rsp.forwardToPreviousPage(req);
     }
 
+    /**
+     * Checks if the current user has a permission to stop this build. 
+     */
+    public boolean hasStopPermission() {
+        try {
+            executable.checkAbortPermission();
+            return true;
+        } catch (AccessDeniedException e) {
+            return false;
+        }
+    }
+
     public Computer getOwner() {
         return owner;
     }

diff --git a/core/src/main/resources/lib/hudson/executors.jelly b/core/src/main/resources/lib/hudson/executors.jelly
@@ -58,9 +58,9 @@
                 <t:buildProgressBar build="${e.currentExecutable}"/>
 	            </td>
 	            <td class="pane" width="16" align="center" valign="middle">
-                <l:isAdmin>
+                <j:if test="${e.hasStopPermission()}">
                   <a href="${rootURL}/computers/${cloop.index}/executors/${eloop.index}/stop"><img src="${imagesURL}/16x16/stop.gif" alt="${%terminate this build}" /></a>
-                </l:isAdmin>
+                </j:if>
 	            </td>
 	          </j:otherwise>
 	        </j:choose>