Simplified TemporaryDirectoryAllocator.dispose

src/main/java/org/jvnet/hudson/test/JenkinsRule.java

@@ -510,13 +510,6 @@ public void after() throws Exception {
             try {
                 env.dispose();
             } finally {
-                // Hudson creates ClassLoaders for plugins that hold on to file descriptors of its jar files,
-                // but because there's no explicit dispose method on ClassLoader, they won't get GC-ed until
-                // at some later point, leading to possible file descriptor overflow. So encourage GC now.
-                // see http://bugs.sun.com/view_bug.do?bug_id=4950148
-                // TODO use URLClassLoader.close() in Java 7
-                System.gc();
-
                 // restore defaultUseCache
                 if(Functions.isWindows()) {
                     URLConnection aConnection = new File(".").toURI().toURL().openConnection();

src/main/java/org/jvnet/hudson/test/TemporaryDirectoryAllocator.java

@@ -23,18 +23,27 @@
  */
 package org.jvnet.hudson.test;
 
-import hudson.FilePath;
-
+import com.google.common.collect.Iterables;
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.DirectoryNotEmptyException;
+import java.nio.file.DirectoryStream;
+import java.nio.file.Files;
+import java.nio.file.LinkOption;
+import java.nio.file.Path;
 import java.util.HashSet;
 import java.util.Set;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 /**
  * Allocates temporary directories and cleans it up at the end.
  * @author Kohsuke Kawaguchi
  */
 public class TemporaryDirectoryAllocator {
+
+    private static final Logger LOGGER = Logger.getLogger(TemporaryDirectoryAllocator.class.getName());
+
     /**
      * Remember allocated directories to delete them later.
      */
@@ -85,25 +94,11 @@ public synchronized File allocate() throws IOException {
      * Deletes all allocated temporary directories.
      */
     public synchronized void dispose() throws IOException, InterruptedException {
-        // TODO when we bump the Jenkins dependency to 2.157
-        IOException x = null;
         for (File dir : tmpDirectories) {
-            try {
-                new FilePath(dir).deleteRecursive();
-            } catch (IOException e) {
-                if (x == null) { 
-                    x = e;
-                }
-                else {
-                    x.addSuppressed(e);
-                }
-            }
+            LOGGER.info(() -> "deleting " + dir);
+            delete(dir.toPath());
         }
         tmpDirectories.clear();
-        if (x != null) {
-           // do not wrap this pending JENKINS-60308
-           throw x;
-        }
     }
 
     /**
@@ -115,13 +110,34 @@ public synchronized void disposeAsync() {
 
         new Thread("Disposing "+base) {
             public void run() {
-                for (File dir : tbr)
+                for (File dir : tbr) {
+                    LOGGER.info(() -> "deleting " + dir);
                     try {
-                        new FilePath(dir).deleteRecursive();
-                    } catch (IOException | InterruptedException e) {
-                        e.printStackTrace();
+                        delete(dir.toPath());
+                    } catch (IOException e) {
+                        LOGGER.log(Level.WARNING, null, e);
                     }
+                }
             }
         }.start();
     }
+
+    private void delete(Path p) throws IOException {
+        LOGGER.fine(() -> "deleting " + p);
+        if (Files.isDirectory(p, LinkOption.NOFOLLOW_LINKS)) {
+            try (DirectoryStream<Path> children = Files.newDirectoryStream(p)) {
+                for (Path child : children) {
+                    delete(child);
+                }
+            }
+        }
+        try {
+            Files.deleteIfExists(p);
+        } catch (DirectoryNotEmptyException x) {
+            try (DirectoryStream<Path> children = Files.newDirectoryStream(p)) {
+                throw new IOException(Iterables.toString(children), x);
+            }
+        }
+    }
+
 }