Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-58038] Use Annotation-Indexer instead of Reflections #141

Merged
merged 5 commits into from
Jun 18, 2019
Merged

[JENKINS-58038] Use Annotation-Indexer instead of Reflections #141

merged 5 commits into from
Jun 18, 2019

Conversation

AbhyudayaSharma
Copy link
Member

Reflections was causing a dependency conflict with the Guava from
Jenkins Core (see: https://travis-ci.org/jenkinsci/configuration-as-code-plugin/jobs/546110907#L878)

@jenkinsci/gsoc2019-role-strategy

@AbhyudayaSharma
Use ClassGraph instead of Reflections
51f0f7b 
Reflections was causing a dependency conflict with the Guava from
Jenkins Core (see: https://travis-ci.org/jenkinsci/configuration-as-code-plugin/jobs/546110907#L878)
@AbhyudayaSharma AbhyudayaSharma mentioned this pull request Jun 17, 2019
Merged
5 tasks
@oleg-nenashev
Copy link
Member

Thanks for the investigation @AbhyudayaSharma! Maybe it would be even better to use sezpoz since it is already included into JTH.

A Jenkins JIRA ticket would be also much appreciated since the previous JTH version has been already released

@AbhyudayaSharma AbhyudayaSharma changed the title Use ClassGraph instead of Reflections [JENKINS-58038] Use SezPoz instead of Reflections Jun 17, 2019
oleg-nenashev
oleg-nenashev approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@jetersen
Copy link
Member

Green built in downstream PR: jenkinsci/configuration-as-code-plugin#921

@oleg-nenashev oleg-nenashev requested a review from jglick June 17, 2019 09:14
@oleg-nenashev
Copy link
Member

My plan is to merge and release it on the evening if there is no negative feedback

@AbhyudayaSharma AbhyudayaSharma changed the title [JENKINS-58038] Use SezPoz instead of Reflections [JENKINS-58038] Use Annotation-Indexer instead of Reflections Jun 17, 2019
jetersen
jetersen approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oleg-nenashev
oleg-nenashev approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AbhyudayaSharma and @jglick ! Should we ship it?

@oleg-nenashev oleg-nenashev requested a review from jglick June 17, 2019 20:56
jglick
jglick approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK from a brief glance.

@oleg-nenashev oleg-nenashev merged commit ca561b8 into jenkinsci:master Jun 18, 2019
@AbhyudayaSharma AbhyudayaSharma deleted the use-classgraph branch June 18, 2019 05:04
@oleg-nenashev oleg-nenashev mentioned this pull request Jun 18, 2019
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jetersen jetersen jetersen approved these changes

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbhyudayaSharma @oleg-nenashev @jetersen @jglick