Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the crumbFlag as the 2nd parameter of getConsoleOutputText method #386

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

iapplejohn
Copy link
Contributor

I need to fetch the progressive text with the crumbFlag setting to true, otherwise, it will return http status 403, no valid crumb was included in the request.

@khmarbaise khmarbaise merged commit ecb8f5e into jenkinsci:master Jan 24, 2019
@mivola
Copy link
Contributor

mivola commented Jan 24, 2019

@khmarbaise are you aware that this is a breaking change? Wouldn't it be better to keep the existing methods (which then forward to the new methods with "crumbFlag=false")?
Furthermore it also solves issue #350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants