Resolve version inconsistency with oauth-credentials #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #188 a dependency inconsistency was introduced by removing the version of oauth-credentials (at that time
0.646.v02b_66dc03d2e
), see:https://github.com/jenkinsci/google-oauth-plugin/pull/188/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L182
and adding a bom version (
2465.va_e76ed7b_3061
) that contains the previous version (0.645.ve666a_c332668
) of oauth-credentials.See bom version added:
https://github.com/jenkinsci/google-oauth-plugin/pull/188/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R89
See version of oauth-credentials in bom:
https://github.com/jenkinsci/bom/blob/2465.va_e76ed7b_3061/bom-weekly/pom.xml#L715
Due to this change when installing the google-oauth-plugin to a vanilla Jenkins (2.426.1) the following exception is thrown:
This originates back to a java API change in the oauth-credentials-plugin, see jenkinsci/oauth-credentials-plugin#16
With the update of the bom version the proper oauth-credentials plugin is registered as a dependency, see changes between the current and the next bom version:
jenkinsci/bom@2465.va_e76ed7b_3061...2483.v3b_22f030990a_#diff-df30c196b4c4872fdfa9378b991827b2433d220d66f83c0f0a1e868010ee3767R720
The PR aims to resolve issues #200 and #204
Testing done
Local maven build passed with the updated bom version.
A locally built hpi file was installed on a vanilla Jenkins (2.426.1), no exceptions were observed.
I'm no expert of dependency chains between different Jenkins plugins, so please take that into consideration, I just followed the clues along the way.
Submitter checklist