-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Jenkins 2.479.1 or newer #346
Conversation
* update to Java 17 * use matching plugin BOM
Used OpenRewrite
Thanks! A similar pull request includes additional changes for the Java EE 8 to Jakarta EE 9 transition. That pull request is: We'll want to highlight the Java EE 8 to Jakarta EE 9 transition in one of our sessions, since that transition is a key component of the 2.479 release. There is an OpenRewrite recipe that is worth trying in our environment. It won't transform StaplerRequest to StaplerRequest2 or StaplerResponse to StaplerResponse2 but it will handle the javax.servlet to jakarta.servlet namespace change. |
Compile with Java 17 and Jakarta EE 9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet ready to merge and release because we need to wait for more users to adopt 2.479.x, but the code changes look good to me.
Prefer LTS baseline rather than a weekly baseline
I think that we've waited long enough. Merging and releasing. |
Used OpenRewrite to convert to Java 17 syntax
Testing done
ran
mvn clean verify
Confirmed that coverage badges extension plugin (the only plugin dependent on this plugin) passes its automated tests with the incremental build of this plugin
Submitter checklist