Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.479.1 or newer #346

Merged
merged 19 commits into from
Dec 20, 2024
Merged

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Oct 16, 2024

Used OpenRewrite to convert to Java 17 syntax

Testing done

ran mvn clean verify

Confirmed that coverage badges extension plugin (the only plugin dependent on this plugin) passes its automated tests with the incremental build of this plugin

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* update to Java 17
* use matching plugin BOM
Used OpenRewrite
@darinpope darinpope requested a review from a team as a code owner October 16, 2024 20:54
@github-actions github-actions bot added the dependencies Dependency related change label Oct 16, 2024
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Oct 16, 2024

Thanks! A similar pull request includes additional changes for the Java EE 8 to Jakarta EE 9 transition. That pull request is:

We'll want to highlight the Java EE 8 to Jakarta EE 9 transition in one of our sessions, since that transition is a key component of the 2.479 release.

There is an OpenRewrite recipe that is worth trying in our environment. It won't transform StaplerRequest to StaplerRequest2 or StaplerResponse to StaplerResponse2 but it will handle the javax.servlet to jakarta.servlet namespace change.

@github-actions github-actions bot added the tests Automated test addition or improvement label Oct 25, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet ready to merge and release because we need to wait for more users to adopt 2.479.x, but the code changes look good to me.

Prefer LTS baseline rather than a weekly baseline
@MarkEWaite MarkEWaite changed the title Require Jenkins 2.479 Require Jenkins 2.479.1 or newer Oct 30, 2024
@MarkEWaite MarkEWaite added rfe Improvement or new feature and removed dependencies Dependency related change tests Automated test addition or improvement labels Nov 1, 2024
@github-actions github-actions bot added dependencies Dependency related change tests Automated test addition or improvement labels Nov 15, 2024
@MarkEWaite MarkEWaite removed dependencies Dependency related change tests Automated test addition or improvement labels Dec 20, 2024
@MarkEWaite
Copy link
Contributor

I think that we've waited long enough. Merging and releasing.

@MarkEWaite MarkEWaite enabled auto-merge (squash) December 20, 2024 21:19
@MarkEWaite MarkEWaite merged commit 5653c6e into jenkinsci:master Dec 20, 2024
18 checks passed
@darinpope darinpope deleted the 11-to-17 branch December 20, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfe Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants